think tank forum

ttf development » Some comments

Carpetsmoker's avatar
17 years ago
link
Carpetsmoker
Martin
I looked at the ttf forum software, and I have a few comments, I have some time so I thought I'd share them ...

Note: I can not properly preview my post and also can not scroll is textarea properly, meaning that this posts will probably contains few spelling errors ... My apologies ...

o When you Login and logout ttf just returns an empty page, a little text/link would be nice

o You should use application/xhtml+xml content-type for xhtml... This is somewhat important because this gets parsed differently by browsers than text/html content does.
A certain browser that shall not be named does not support this, a workaround is:

if (stristr($_SERVER['HTTP_ACCEPT'], 'application/xhtml+xml'))
header('Content-Type: application/xhtml+xml; charset=utf-8');
else
header('Content-Type: text/html; charset=utf-8');

Note that any form of proper parsing of HTTP_ACCEPT will not work, this is also broken in the same browser we shall not name ...

o For some reason all the code is indented with spaces, this is because of "set expandtab"
why?
The main reason I'm not making these changes myself is because the code is just uneditable for me mainly because of this ...

o Templates
Now the code is a ugly mix of PHP and HTML, seperating this would not only allow users to switch styles, it would also increase readability of the code and makes it easier to maintain.

A "template engine" doesn't need to be that complicated or difficult, for for example look at my app mailview (http://www.carpetsmoker.net/mailview/) function HtmlTemplate()

o For some reason scrolling this texarea is difficult/awkward (Opera browser).

o This page also looks weird in opera:
http://www.rwxrwxrwx.net/ttf.png

o Preview post!
I need this, I am an idiot and need to view my posts 10 times before I get all the errors out ...

o I can't edit my own posts (Aside from previewing them 10 times, I also need to edit them 4 times because a few errors *always* slip through).

o A thread is created as soon as I use "create thread", not after I enter the first post ... Is this intentional?

o The "next 15 threads" button on the right side is not obvious ... it took me 10 minutes before I found it ...

o Maybe using something like PDO (Or any of the similair projects) would be something to consider?
Right now MySQL and MySQL *only* can be used ... :(
lucas's avatar
17 years ago
r1, link
lucas
i ❤ demo
this post has been archived.
lucas's avatar
17 years ago
link
lucas
i ❤ demo
i'll reply later tonight or tomorrow.
lucas's avatar
17 years ago
r1, link
lucas
i ❤ demo
this post has been archived.
lucas's avatar
17 years ago
link
lucas
i ❤ demo
thanks for taking the time to post your thoughts!

When you Login and logout ttf just returns an empty page, a little text/link would be nice



i haven't seen this happen. can you give me steps to replicate, please?

You should use application/xhtml+xml content-type for xhtml... This is somewhat important because this gets parsed differently by browsers than text/html content does.



i've had problems with css rendering when i tell it to parse as application/xhtml+xml. for example, the background doesn't extend the length of the browser window. does css change markedly for the different parsing? what browser are you talking about?

For some reason all the code is indented with spaces, this is because of "set expandtab"
why?
The main reason I'm not making these changes myself is because the code is just uneditable for me mainly because of this ...



because the other developers i have worked with like tabs expanded. and i hate a mix of tabs and spaces. at least this is forced consistency with all spaces. why is it uneditable?

Templates
Now the code is a ugly mix of PHP and HTML, seperating this would not only allow users to switch styles, it would also increase readability of the code and makes it easier to maintain.



you're probably right. there are many things that i'd like to resolve before this, however.

For some reason scrolling this texarea is difficult/awkward (Opera browser).



yeah, it is terrible in opera. i've spent many hours trying to resolve the css across all platforms and browsers to no avail. but it's fixed with a new layout in trunk.

This page also looks weird in opera



this is also documented and fixed in trunk.

Preview post!
I need this, I am an idiot and need to view my posts 10 times before I get all the errors out



it's a possibility, but it's low priority.

I can't edit my own posts



well aware, well documented, and you can in trunk.

A thread is created as soon as I use "create thread", not after I enter the first post ... Is this intentional?



it was indeed intentional. but i decided that it's not optimal and it has been changed in trunk.

The "next 15 threads" button on the right side is not obvious ... it took me 10 minutes before I found it ...



i have no plans to change this design. feel free to submit a mock-up.

Maybe using something like PDO (Or any of the similair projects) would be something to consider?
Right now MySQL and MySQL *only* can be used ... :(



i have no intention of coding support for other formats. i will accept working patches, however.
asemisldkfj's avatar
17 years ago
link
asemisldkfj
the law is no protection
I might take you up on the mockup of the page navigation at some point. I hate how it works now. not so much the placement, but how it doesn't tell you what page you're on and there's no way to do "previous fifteen threads" or whatever it is.
lucas's avatar
17 years ago
link
lucas
i ❤ demo
:)
Carpetsmoker's avatar
17 years ago
r1, link
Carpetsmoker
Martin
this post has been archived.