think tank forum

when I go to search.php it's giving me an error message that no search terms were entered. this is without clicking the "search" submit button.

I looked at the code and there is an if statement that looks like it's supposed to check if the search box is empty, but I guess it's not working correctly right now?

I've never noticed this before, so maybe I have a slightly older version of the code from before it was broken. I checked it out maybe a week ago.

thanks. this is actually fixed in trunk, it just hasn't been merged into the live branch yet (and is thus not online).

you'll see the fixed search code here:
http://thinktankforums.googlecode.com/svn/trunk/search.php

note: this was fixed in branches/live/search.php with r43.

thanks, asemi.

everyone: please report bugs! :d

yay! next time I'll fix it myself :).

also, for future reference, how would you like proposed changes submitted? diffs? just a copy of the modified file? do I have permission to upload code to the Google Code SVN repository?

yeah, you have a commit bit.

feel free to commit stuff. if i don't like what you're doing, i'll tell you.

i'd also gladly accept diffs, modified files, etc.

it needs to search the thread titles as well. i just searched for "natasha", "wescoat", and "natasha wescoat" and got no results.

but: http://www.thinktankforums.com/thread.php?thread_id=484

upon opening the search page can you make the text cursor default to the box?

search doesn't include thread titles... i can't go to "now playing"

i know :/

it's a known bug that will be fixed eventually (3 weeks? that's when i'm quitting my jobs)