think tank forum

ttf development » editprofile.php

maple's avatar
18 years ago
link
maple
i like large datasets
hey lr,

i've rewritten alot of the editprofile.php page to have a only two submit buttons. one for avatar and the other for all the rest of the info. added some extra checks for that and got the code a quite a bit smaller. i still need to tweak some stuff but i didnt know how you wanted to handle it. i would rather show it to you (the look and the code) before committing it since its such a big change. let me know what you think.
lucas's avatar
18 years ago
link
lucas
i ❤ demo
i would actually prefer that you just commit it, then we can all take a look at it.

i understand that you might want to run ideas by us before you start coding, but if you have already coded it just commit it and we'll play with it.
maple's avatar
18 years ago
link
maple
i like large datasets
awesome. should commit tonight!
maple's avatar
18 years ago
link
maple
i like large datasets
backed out of making the huge commit, but made a few smaller ones that ended up being cleaner anyway.

let me know what you guys think.
lucas's avatar
18 years ago
link
lucas
i ❤ demo
it's pretty good, i'm trying to figure out why ($profile != $user["profile"]) is always evaluated as true on line 66 of editprofile.php. $profile is taking \r\n literally, while $user["profile"] isn't.

just go to the page and hit "apply" and it will always change your profile.
maple's avatar
18 years ago
link
maple
i like large datasets
yeah i hadn't noticed that because i was using a single line profile in my dev environment, but when i added a second line it happend...
lucas's avatar
18 years ago
link
lucas
i ❤ demo
oh, and there's no message if you click apply without changing anything.

if you don't fix it up by tomorrow, i'll finish it tomorrow after my physics exam. it's not a big deal--i don't care much about trunk. although i do typically run trunk live on thinktankforums.com.

i appreciate the contributions!
maple's avatar
18 years ago
link
maple
i like large datasets
fixed both issues
lucas's avatar
18 years ago
link
lucas
i ❤ demo
awesome.. looks good.